Change latching behaviour of "last_word_in" latches

During testing a scenario arose, where a toggling in the last_word
signal lane while the rest of the signals were not valid was falsely
latched.
All entities with "last_word_in" latches were modifies to only latch
the signal when in valid state.

src/TEMPLATE_key_holder.vhd

@@ -135,7 +135,7 @@ begin
         -- ###GENERATED END###
         
         -- Last Word Latch Setter
-        if (last_word_in = '1') then
+        if (last_word_in = '1' and valid_in = '1') then
             last_word_in_latch_next <= '1';
         end if;
         

src/TEMPLATE_reader_interface.vhd

@@ -161,7 +161,7 @@ begin
         -- ###GENERATED END###
         
         -- Last Word Latch Setter
-        if (last_word_in_dds = '1') then
+        if (last_word_in_dds = '1' and valid_in_dds = '1') then
             last_word_in_latch_next <= '1';
         end if;
         

src/Tests/Type1_key_holder.vhd

@@ -131,7 +131,7 @@ begin
         -- ###GENERATED END###
         
         -- Last Word Latch Setter
-        if (last_word_in = '1') then
+        if (last_word_in = '1' and valid_in = '1') then
             last_word_in_latch_next <= '1';
         end if;
         

src/Tests/Type1_reader_interface.vhd

@@ -161,7 +161,7 @@ begin
         -- ###GENERATED END###
         
         -- Last Word Latch Setter
-        if (last_word_in_dds = '1') then
+        if (last_word_in_dds = '1' and valid_in_dds = '1') then
             last_word_in_latch_next <= '1';
         end if;
         

src/Tests/Type2_key_holder.vhd

@@ -173,7 +173,7 @@ begin
         -- ###GENERATED END###
         
         -- Last Word Latch Setter
-        if (last_word_in = '1') then
+        if (last_word_in = '1' and valid_in = '1') then
             last_word_in_latch_next <= '1';
         end if;
         

src/Tests/Type2_reader_interface.vhd

@@ -490,7 +490,7 @@ begin
         -- ###GENERATED END###
         
         -- Last Word Latch Setter
-        if (last_word_in_dds = '1') then
+        if (last_word_in_dds = '1' and valid_in_dds = '1') then
             last_word_in_latch_next <= '1';
         end if;
         

src/ros2/TEMPLATE_ros_action_goal_srv_client.vhd

@@ -201,7 +201,7 @@ begin
         -- ###GENERATED END###
         
         -- Last Word Latch Setter
-        if (last_word_in_r = '1') then
+        if (last_word_in_r = '1' and valid_in_r = '1') then
             last_word_in_latch_next <= '1';
         end if;
         -- Data Available Setter

src/ros2/TEMPLATE_ros_action_goal_srv_server.vhd

@@ -197,7 +197,7 @@ begin
         -- ###GENERATED END###
         
         -- Last Word Latch Setter
-        if (last_word_in_r = '1') then
+        if (last_word_in_r = '1' and valid_in_r = '1') then
             last_word_in_latch_next <= '1';
         end if;
         -- Data Available Setter

src/ros2/TEMPLATE_ros_action_result_srv_client.vhd

@@ -197,7 +197,7 @@ begin
         -- ###GENERATED END###
         
         -- Last Word Latch Setter
-        if (last_word_in_r = '1') then
+        if (last_word_in_r = '1' and valid_in_r = '1') then
             last_word_in_latch_next <= '1';
         end if;
         -- Data Available Setter

src/ros2/TEMPLATE_ros_action_result_srv_server.vhd

@@ -194,7 +194,7 @@ begin
         -- ###GENERATED END###
         
         -- Last Word Latch Setter
-        if (last_word_in_r = '1') then
+        if (last_word_in_r = '1' and valid_in_r = '1') then
             last_word_in_latch_next <= '1';
         end if;
         -- Data Available Setter

src/ros2/TEMPLATE_ros_srv_client.vhd

@@ -193,7 +193,7 @@ begin
         -- ###GENERATED END###
         
         -- Last Word Latch Setter
-        if (last_word_in_r = '1') then
+        if (last_word_in_r = '1' and valid_in_r = '1') then
             last_word_in_latch_next <= '1';
         end if;
         -- Data Available Setter

src/ros2/TEMPLATE_ros_srv_server.vhd

@@ -190,7 +190,7 @@ begin
         -- ###GENERATED END###
         
         -- Last Word Latch Setter
-        if (last_word_in_r = '1') then
+        if (last_word_in_r = '1' and valid_in_r = '1') then
             last_word_in_latch_next <= '1';
         end if;
         -- Data Available Setter

src/ros2/TEMPLATE_ros_sub.vhd

@@ -147,7 +147,7 @@ begin
         -- ###GENERATED END###
         
         -- Last Word Latch Setter
-        if (last_word_in_dds = '1') then
+        if (last_word_in_dds = '1' and valid_in_dds = '1') then
             last_word_in_latch_next <= '1';
         end if;
         -- Data Available Setter

src/ros2/example_interfaces/AddTwoInts_ros_srv_client.vhd

@@ -190,7 +190,7 @@ begin
         -- ###GENERATED END###
         
         -- Last Word Latch Setter
-        if (last_word_in_r = '1') then
+        if (last_word_in_r = '1' and valid_in_r = '1') then
             last_word_in_latch_next <= '1';
         end if;
         -- Data Available Setter

src/ros2/example_interfaces/AddTwoInts_ros_srv_server.vhd

@@ -190,7 +190,7 @@ begin
         -- ###GENERATED END###
         
         -- Last Word Latch Setter
-        if (last_word_in_r = '1') then
+        if (last_word_in_r = '1' and valid_in_r = '1') then
             last_word_in_latch_next <= '1';
         end if;
         -- Data Available Setter

src/ros2/example_interfaces/Fibonacci_ros_action_feedback_sub.vhd

@@ -192,7 +192,7 @@ begin
         -- ###GENERATED END###
         
         -- Last Word Latch Setter
-        if (last_word_in_dds = '1') then
+        if (last_word_in_dds = '1' and valid_in_dds = '1') then
             last_word_in_latch_next <= '1';
         end if;
         -- Data Available Setter

src/ros2/example_interfaces/Fibonacci_ros_action_goal_srv_client.vhd

@@ -199,7 +199,7 @@ begin
         -- ###GENERATED END###
         
         -- Last Word Latch Setter
-        if (last_word_in_r = '1') then
+        if (last_word_in_r = '1' and valid_in_r = '1') then
             last_word_in_latch_next <= '1';
         end if;
         -- Data Available Setter

src/ros2/example_interfaces/Fibonacci_ros_action_goal_srv_server.vhd

@@ -197,7 +197,7 @@ begin
         -- ###GENERATED END###
         
         -- Last Word Latch Setter
-        if (last_word_in_r = '1') then
+        if (last_word_in_r = '1' and valid_in_r = '1') then
             last_word_in_latch_next <= '1';
         end if;
         -- Data Available Setter

src/ros2/example_interfaces/Fibonacci_ros_action_result_srv_client.vhd

@@ -236,7 +236,7 @@ begin
         -- ###GENERATED END###
         
         -- Last Word Latch Setter
-        if (last_word_in_r = '1') then
+        if (last_word_in_r = '1' and valid_in_r = '1') then
             last_word_in_latch_next <= '1';
         end if;
         -- Data Available Setter

src/ros2/example_interfaces/Fibonacci_ros_action_result_srv_server.vhd

@@ -232,7 +232,7 @@ begin
         -- ###GENERATED END###
         
         -- Last Word Latch Setter
-        if (last_word_in_r = '1') then
+        if (last_word_in_r = '1' and valid_in_r = '1') then
             last_word_in_latch_next <= '1';
         end if;
         -- Data Available Setter

src/ros2/rcl_interfaces/action_msgs/CancelGoal_ros_srv_client.vhd

@@ -271,7 +271,7 @@ begin
         -- ###GENERATED END###
         
         -- Last Word Latch Setter
-        if (last_word_in_r = '1') then
+        if (last_word_in_r = '1' and valid_in_r = '1') then
             last_word_in_latch_next <= '1';
         end if;
         -- Data Available Setter

src/ros2/rcl_interfaces/action_msgs/CancelGoal_ros_srv_server.vhd

@@ -270,7 +270,7 @@ begin
         -- ###GENERATED END###
         
         -- Last Word Latch Setter
-        if (last_word_in_r = '1') then
+        if (last_word_in_r = '1' and valid_in_r = '1') then
             last_word_in_latch_next <= '1';
         end if;
         -- Data Available Setter

src/ros2/rcl_interfaces/action_msgs/GoalStatusArray_ros_sub.vhd

@@ -254,7 +254,7 @@ begin
         -- ###GENERATED END###
         
         -- Last Word Latch Setter
-        if (last_word_in_dds = '1') then
+        if (last_word_in_dds = '1' and valid_in_dds = '1') then
             last_word_in_latch_next <= '1';
         end if;
         -- Data Available Setter

src/rtps_discovery_module.vhd

@@ -852,7 +852,7 @@ begin
         data_out_sig                    <= (others => '0');
         
         -- Last Word Latch Setter
-        if (last_word_in = '1') then
+        if (last_word_in = '1' and empty = '0') then
             last_word_in_latch_next <= '1';
         end if;
         

src/rtps_reader.vhd

@@ -629,7 +629,7 @@ begin
         
         -- Last Word Latch Setter
         -- NOTE: Assumes meta and user traffic are not consumed concurrently
-        if (last_word_in_user = '1' or last_word_in_meta = '1') then
+        if ((last_word_in_user = '1' and empty_user /= (empty_user'range => '1')) or (last_word_in_meta = '1' and empty_meta /= (empty_meta'range => '1'))) then
             last_word_in_latch_next <= '1';
         end if;
         

src/rtps_writer.vhd

@@ -671,7 +671,7 @@ begin
         
         -- Last Word Latch Setter
         -- NOTE: Assumes meta and user traffic are not consumed concurrently
-        if (last_word_in_user = '1' or last_word_in_meta = '1') then
+        if ((last_word_in_user = '1' and empty_user /= (empty_user'range => '1')) or (last_word_in_meta = '1' and empty_meta /= (empty_meta'range => '1'))) then
             last_word_in_latch_next    <= '1';
         end if;