Commit Graph

205 Commits

Author SHA1 Message Date
b7fd9bfcfe BUG FIX: Decoder may not read last byte of payload
The SKIP_PAYLOAD stage of decoders would not read the last word
(last_word_in = '1').
The <NAME>_MEMBER_END stage was removed from encoders/decoders, since it
could happen that the last aggregated member of a last collection entry
could also be the last type member overall, which would miss toggling
the "last_word_out" correctly. The logic was instead put inside the last
member stage (instead of defining a separate MEMEBR_END stage).
2022-02-03 15:05:10 +01:00
a26faff89a Move functions between rtps_package and rtps_config_package 2022-02-03 14:35:54 +01:00
dc47f72942 Add Fibonacci Action Feedback Topic 2022-02-01 15:26:58 +01:00
45556ab136 Add ROS Action Documentation/References 2022-02-01 14:58:03 +01:00
84220120e5 Add Bound checks in Decoder stage 2022-02-01 14:58:02 +01:00
Greek
98e50e89a9 Add ROS Service Server/Client TEMPLATE 2022-02-01 14:58:02 +01:00
Greek
80eb517eda CYCLONE DDS COMPATIBILITY: Disable PUSH_MODE
It seems that Cyclone DDS discards a DATA message before it has received
a HEARTBEAT, but still ACKs it in the ACKNACKs.
2022-02-01 14:58:02 +01:00
Greek
fcbb6f12f5 BUG FIX: Livelock in rtps_writer when PUSH_MODE=FALSE & DURABILITY=TRANSIENT_LOCAL
A Flag was not reset in a sub-branch that is taken when PUSH_MODE=FALSE
& DURABILITY=TRANSIENT_LOCAL, that prevented the RTPS writer from ever
sending HEARTBEATs.
2022-02-01 14:58:02 +01:00
Greek
a2e00cf0f5 BUG FIX: Service uses 2 seperate Typenames for Request/response 2022-02-01 14:58:02 +01:00
Greek
854b62a379 Add CLOCK_PERIOD to ros_config 2022-02-01 14:58:01 +01:00
Greek
0396097f05 BUG FIX: Subscriber and Publisher ACKNACK destinations were flipped 2022-02-01 14:57:50 +01:00
Greek
6524ad6c0d Make ROS Service Topic Generation compatible with Cyclone DDS
Cyclone DDS appends "Reply" (instead of "Response") to the Response
Message Topic.
2022-01-29 11:12:32 +01:00
Greek
39b7e6960a Fix bug in ROS discovery data generation
The Payload Encapsulation was wrongly set to PL_CDR_BE
2022-01-29 11:12:32 +01:00
Greek
f63fccdcc1 Add/Modify synthesis entities to synthesize AddTwoInts_srv_server 2022-01-29 11:12:32 +01:00
Greek
5894fd9121 Add Level 2 ROS Service Test (AddTwoInts) 2022-01-29 11:12:31 +01:00
Greek
b5741dc9ae Implement ROS glue logic & ROS discovery data
All the necessary "glue" logic to convert ROS Data to a form that the
DDS/RTPS back-end can use is implemented in packages.
The ROS Node discovery information is statically generated in packages
(similar to the RTPS Participant Data), and a special dds writer is
implemented (ros_static_discovery_writer) that has this static data as
its only payload sample.
Some definitions are moved out of rtps_config_package to prevent
circular package dependency.
2022-01-29 11:12:22 +01:00
Greek
2d3c5cf896 Add MAX_PAYLOAD_SIZE to Endpoint Config Record 2022-01-25 17:58:14 +01:00
Greek
63ce5642de Add AddTwoInts ROS Service Implementation
A complete ROS service server and client implementation of the
example_interfaces AddTwoInts service is done, along with an acompaning
testbench.
2022-01-24 17:53:07 +01:00
Greek
a99b8f13c8 Code Refactoring 2022-01-24 17:52:58 +01:00
Greek
59bff52832 Rename rtps_builtin_endpoint to rtps_discovery_module 2022-01-16 18:12:11 +01:00
Greek
e0280ea490 Define RTPS/DDS Configuration in record type 2022-01-16 16:16:58 +01:00
da5eb1ad07 Add IDL definitions for ROS2 MSG and SRV 2022-01-07 13:06:18 +01:00
Greek
3ee4769c52 Rename *_wrapper to *_interface
Since the Type Specific user facing entities did not actually wrap the
DDS entities, but connected to them through port signals, a more
semantically correct name would be "interface", since they are the user
facing interface of the DDS entities.
2022-01-03 14:25:27 +01:00
Greek
4b81cf9484 Propagate LIFESPAN through ENDPOINT_MATCH_FRAME instead of inline QoS
Since we disabled the 'expectsInlineQoS' Flag due to Cyclone DDS
compatibility, we no longer have access to the lifespan of the remote
writers.
The Endpoint Match Format was changed to also send the Lifespan Duration
from the rtps_builtin_endpoint.
2021-12-23 16:20:18 +01:00
Greek
56b80bead2 Match rtps_reader with remote writers (not readers) in testbench 2021-12-23 12:19:19 +01:00
Greek
bc37679d40 BUG FIX: Parse whole Endpoint Match Package in rtps_reader 2021-12-23 12:19:18 +01:00
Greek
97e55ff623 Modify rtps_writer
ACK HANDLING
------------
If there are no remote reliable reader endpoints the new Cache Changes
are immediately ACKed/removed from the HC.
Internal Global ACK SN is set to SEQUENCENUMBER_UNKNOWN, and
only initialized on first reliable remote reader endpoint.
If all remote reliable reader endpints are unmatched the internal Global
ACK SN is set to SEQUENCENUMBER_UNKNOWN and all Cache Changes are
ACKed/removed from the HC.
PUSH MODE
---------
Historical DATA is no longer send on remote endpoint match, if PUSH mode
is FALSE.
TESTBENCH
---------
Level 1 Test2 of rtps_writer was split into 2 tests.
2021-12-23 12:19:11 +01:00
Greek
20dff4a208 BUG FIX: Default Reliability is different for Readers and Writers 2021-12-15 16:49:32 +01:00
Greek
3a1aeb818e Remove TRANSPORT_PRIORITY_QOS
According to RTPS Specification, the TRANSPORT_PRIORITY_QOS is only for
Topic Data.
2021-12-15 16:30:31 +01:00
Greek
6d609a5a34 CYCLONE DDS Compatibility: Remove expectsinlineQoS Flag
Apparently Cyclone DDS does not support Readers with the inline QoS
Flag.
Change rtps_test_package to generate only necessary PIDs (e.g. no
PID_EXPECTS_INLINE_QOS for writers)
2021-12-15 15:58:07 +01:00
Greek
49fc01cf6b BUG FIX: rtps_handler was droping valid ACKNACKs and GAPs
The rtps_handler was droping SequenceNumberSets where the 0 bit was set.
The rtps_handler Test1 was also extended a bit to test for more invalid
variants.
2021-12-14 13:09:10 +01:00
Greek
ef32055f21 BUG FIX: is_live_assert Flag never reset in rtps_builtin_endpoint 2021-12-13 19:07:07 +01:00
Greek
02f0fbfb98 Add PREFER_MULTICAST generic in rtps_buildin_endpoint
Until now the rtps_builtin_endpoint was using the last parsed Locator as
the Locator of choice.
The rtps_builtin_endpoint was extended with a PREFER_MULTICAST boolean
generic that allows to influence which locators are used.
Test1 of rtps_builtin_endpoint was split in two, to test both settings
of the generic.
2021-12-13 14:31:33 +01:00
Greek
719766f5ed BUG FIX: rtps_builtin_endpoint does double endian swap (pre-swaped by rtps_handler) 2021-12-13 14:30:15 +01:00
Greek
48468d1131 BUG FIX: PID is affected by endianness 2021-12-11 12:20:52 +01:00
Greek
e65b152bc6 Modify Level 2 testcases (Test also Altera Implementations)
One Library of each Level 2 testbench is compiled with the Altera
implementations of FIFO and RAM.
2021-12-09 23:32:18 +01:00
Greek
965e7fbb4a TIMING CLOSURE: Further Sub-Split FIND_NEXT_INSTANCE in dds_reader
The FIND_NEXT_INSTANCE stage of the dds_reader was doing a 128-bit
comparison (Key Hash) in 1 clock cycle.
The comparison was split among 4 clock cycles.
2021-12-09 23:32:18 +01:00
Greek
4841d0a6bb Add synthesis Test6 2021-12-09 23:32:18 +01:00
Greek
1fdf2198ba TIMING CLOSURE: Further Sub-Split PARTICIPANT_STALE_CHECK in rtps_builtin_endpoint
The PARTICIPANT_STALE_CHECK stage of the rtps_builtin_endpoint was doing
4 consecutive 64-bit comparisons in the same clock cycle.
The stage was further sub-split to make one 64-bit comparison per clock cycle.
2021-12-09 23:32:18 +01:00
Greek
f13d28d811 Add/Modify synthesis entities to synthesize test_loopback 2021-12-09 23:32:08 +01:00
Greek
4896929e1b code refactoring 2021-12-09 19:44:40 +01:00
Greek
3e387b9513 Bug Fix in TYPENAME_writer_wrapper
Default output was missing, inferring latch in synthesis
2021-12-09 19:44:40 +01:00
Greek
c88d4ccf07 Modify rtps_out to use Dual Port RAM 2021-12-09 19:44:40 +01:00
Greek
622ebf6083 Add Dual Port Memory Controller 2021-12-09 19:44:40 +01:00
Greek
46ca2228b6 Add and Redefine existing Dual Port RAM Implementations
Simple Dual Port (Read and Write Port), and True Dual Port RAM
implementations, together with their respective Altera implementations
were added.
The 'arch' Architectures should have the same behaviour as the Altera
Implementations (single_port_ram was modified to achieve that)
2021-12-09 19:44:40 +01:00
Greek
1871adac6d Add a Verbatim Key Hash Generator
Add a Key Hash Generator that just generates a Key Hash with the
verbatim contents of the Type Key Fields.
This is the case for all Types with a combined Key Field size less than
16 Bytes.
2021-12-09 19:44:39 +01:00
Greek
6662935514 Add dds_top TEMPLATE 2021-12-09 19:44:39 +01:00
Greek
e0453657ba Add Test2 Level 2 testbench
A loopback is implemented between 2 seperate systems with one reader and
one writer each. Type1 Topic Type is used.
2021-12-09 19:44:39 +01:00
Greek
70549853d5 code refactoring 2021-12-09 19:44:39 +01:00
Greek
4420a62d63 Fix Bug in Key Holder
The Key Holder was sending only the 1st Byte of 4-Byte Key Fields.
2021-12-09 19:44:39 +01:00